Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no spacing between form fields and FormLabel and FormHelperText when labelPosition="left" #1281

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Apr 13, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

No

Summary

Fix no spacing between form fields and FormLabel and FormHelperText when labelPosition="left".

Details

Skip

Breaking change or not (Yes/No)

No

References

No

@sungik-choi sungik-choi added the fix PR related to bug fix label Apr 13, 2023
@sungik-choi sungik-choi self-assigned this Apr 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

🦋 Changeset detected

Latest commit: 31b3e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi sungik-choi changed the title Fix no spacing between FormField and FormLabel and FormHelperText when labelPosition="left". Fix no spacing between Form Fields and FormLabel and FormHelperText when labelPosition="left". Apr 13, 2023
@sungik-choi sungik-choi force-pushed the fix/form-control-left-gap branch from cae1c7a to 31b3e00 Compare April 13, 2023 07:38
@sungik-choi sungik-choi changed the title Fix no spacing between Form Fields and FormLabel and FormHelperText when labelPosition="left". Fix no spacing between form fields and FormLabel and FormHelperText when labelPosition="left". Apr 13, 2023
@sungik-choi sungik-choi changed the title Fix no spacing between form fields and FormLabel and FormHelperText when labelPosition="left". Fix no spacing between form fields and FormLabel and FormHelperText when labelPosition="left" Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc3c148) 78.16% compared to head (31b3e00) 78.16%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1281   +/-   ##
========================================
  Coverage    78.16%   78.16%           
========================================
  Files          294      294           
  Lines         3796     3796           
  Branches       839      839           
========================================
  Hits          2967     2967           
  Misses         545      545           
  Partials       284      284           
Impacted Files Coverage Δ
...components/Forms/FormControl/FormControl.styled.ts 100.00% <ø> (ø)
...t/src/components/Forms/FormControl/FormControl.tsx 91.83% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 123f4cd into channel-io:next-v1 Apr 13, 2023
@sungik-choi sungik-choi deleted the fix/form-control-left-gap branch April 13, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant