-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove overrided padding from valueItemContainer #1290
remove overrided padding from valueItemContainer #1290
Conversation
🦋 Changeset detectedLatest commit: b1665cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
d8f03fe
to
dd7f3ce
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1290 +/- ##
========================================
Coverage 78.16% 78.16%
========================================
Files 294 294
Lines 3796 3796
Branches 839 839
========================================
Hits 2967 2967
Misses 545 545
Partials 284 284
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
라벨 bug
-> fix
로 변경했습니다!
Self Checklist
CODEOWNERS
file.Related Issue
Fixes #0000
Summary
Current
Figma ScreenShot
Fixed
So remove padding property from
ValueItemContainer
in order to fix it.현재
ValueItemContainer
의 패딩은0 6px
인데, 이것은 피그마의 패딩과 다릅니다.이로 인해 데스크에서 MultiIine 컴포넌트가 한줄일때 이상해보이는 문제점이 있었습니다.
현재 스타일은 기존의 padding인
4px 6px
를 오버라이드하므로, 이를 삭제하여 원래 패딩을 사용하도록합니다.Breaking change or not (Yes/No)
References
Figma