Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove overrided padding from valueItemContainer #1290

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

Kanary159357
Copy link
Contributor

@Kanary159357 Kanary159357 commented Apr 18, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Fixes #0000

Summary

Current

image

Figma ScreenShot

image

Fixed

image

So remove padding property from ValueItemContainer in order to fix it.

현재 ValueItemContainer의 패딩은 0 6px인데, 이것은 피그마의 패딩과 다릅니다.

이로 인해 데스크에서 MultiIine 컴포넌트가 한줄일때 이상해보이는 문제점이 있었습니다.

현재 스타일은 기존의 padding인 4px 6px를 오버라이드하므로, 이를 삭제하여 원래 패딩을 사용하도록합니다.

Breaking change or not (Yes/No)

References

Figma

@Kanary159357 Kanary159357 self-assigned this Apr 18, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: b1665cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@Kanary159357 Kanary159357 force-pushed the fix/key-value-item-css branch from d8f03fe to dd7f3ce Compare April 18, 2023 07:58
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c778a92) 78.16% compared to head (b1665cb) 78.16%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1290   +/-   ##
========================================
  Coverage    78.16%   78.16%           
========================================
  Files          294      294           
  Lines         3796     3796           
  Branches       839      839           
========================================
  Hits          2967     2967           
  Misses         545      545           
  Partials       284      284           
Impacted Files Coverage Δ
...yValueListItem/KeyValueMultiLineListItem.styled.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kanary159357 Kanary159357 added the bug Issues related to anything that isn't working label Apr 18, 2023
@Kanary159357 Kanary159357 marked this pull request as ready for review April 18, 2023 08:06
@sungik-choi sungik-choi added fix PR related to bug fix and removed bug Issues related to anything that isn't working labels Apr 19, 2023
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

라벨 bug -> fix 로 변경했습니다!

@Kanary159357 Kanary159357 merged commit e777328 into channel-io:next-v1 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants