Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing a number to the width prop of a SegmentedControl to work correctly #1339

Merged

Conversation

sungik-choi
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

Fix passing a number to the width prop of a SegmentedControl to work correctly

Details

None

Breaking change or not (Yes/No)

No

References

None

@sungik-choi sungik-choi added the fix PR related to bug fix label May 12, 2023
@sungik-choi sungik-choi self-assigned this May 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: e0ea8c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (22b1221) 84.27% compared to head (e0ea8c1) 84.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1339      +/-   ##
===========================================
- Coverage    84.27%   84.25%   -0.02%     
===========================================
  Files          309      309              
  Lines         3917     3919       +2     
  Branches       803      804       +1     
===========================================
+ Hits          3301     3302       +1     
  Misses         546      546              
- Partials        70       71       +1     
Impacted Files Coverage Δ
...onents/Forms/SegmentedControl/SegmentedControl.tsx 94.44% <50.00%> (-2.62%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sungik-choi sungik-choi merged commit f674fc3 into channel-io:next-v1 May 12, 2023
@sungik-choi sungik-choi deleted the fix/segmented-control-width branch May 12, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant