Set up rollup and package json for SCSS #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungik-choi
added
build
🦋 Changeset detectedLatest commit: 5319a5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## styled-system #1491 +/- ##
==============================================
Coverage 87.27% 87.27%
==============================================
Files 279 279
Lines 3835 3835
Branches 806 806
==============================================
Hits 3347 3347
Misses 415 415
Partials 73 73 ☔ View full report in Codecov by Sentry. |
sungik-choi
force-pushed
the
feat/scss-build
branch
from
1cd06e5 to
5319a5f
Compare
sungik-choi
added a commit
that referenced
this pull request
Jul 13, 2023
* feat(styles): add rollup-postcss-plugin and set up build config * chore(pkg): add css files to side effects and sub path module * chore(changeset): add changeset * build(rollup): add custom generate scoped name string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
CODEOWNERSfile.Related Issue
Summary
from b55b75d
SCSS module을 빌드할 수 있는 환경을 구성합니다
Details
sass,postcss를 사용하여 직접 롤업 플러그인을 구성하는 방법을 고려해보았지만, 1. 빠른 시간 안에 구현은 조금 어려울 듯하고 2. 해당 라이브러리로 원하는 동작이 충분히 잘 구현되어 라이브러리를 사용하기로 결정했습니다.autoprefixerpostcss 플러그인을 추가합니다. (+ 현재 브라우저 리스트 기준 vendor prefix가 필요한 케이스는 없음)Breaking change or not (Yes/No)
Yes
이제 bezier-react에서 스타일 시트를 export 합니다. 앱의 루트에서 아래와 같이 스타일 시트를 import 해야합니다.
References