Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rollup): add browser exports condition to module resolve #1637

Merged
merged 2 commits into from
Sep 18, 2023
Merged

build(rollup): add browser exports condition to module resolve #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0efdf18
build(rollup): add browser exports condition to module resolve
sungik-choi Sep 18, 2023
2ff689e
chore(changeset): add changeset
sungik-choi Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-cars-perform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@channel.io/bezier-react": patch
---

Fixes an issue where the height of `TextArea` component is not specified correctly. Modify the build settings to match the package.json exports fields change in 8.5.0 of `react-textarea-autosize`.
5 changes: 4 additions & 1 deletion packages/bezier-react/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ const generateConfig = ({
peerDeps: true,
packagePath: './package.json',
}),
nodeResolve({ extensions }),
nodeResolve({
browser: true,
extensions,
}),
/**
* **IMPORTANT**: Order matters!
* When using @rollup/plugin-babel with @rollup/plugin-commonjs in the same Rollup configuration,
Expand Down