Add codemod for z-index interpolation

.changeset/slimy-lobsters-sparkle.md

@@ -0,0 +1,5 @@
+---
+"@channel.io/bezier-codemod": minor
+---
+
+Add codemod for z-index interpolation and enum

packages/bezier-codemod/README.md

@@ -203,6 +203,37 @@ const Wrapper = styled.div`
 `;
 ```
 
+**`v2-z-index-interpolation-to-css-variable`**
+
+Replace z-index interpolation to css variable
+For example:
+
+```tsx
+import { ZIndex, styled } from "@channel.io/bezier-react";
+
+const OVERLAY_POSITION = {
+  zIndex: ZIndex.Modal,
+};
+
+const Wrapper = styled.div`
+  z-index: ${ZIndex.Hide};
+`;
+```
+
+Transforms into:
+
+```tsx
+import { styled } from "@channel.io/bezier-react";
+
+const OVERLAY_POSITION = {
+  zIndex: "var(--z-index-modal)",
+};
+
+const Wrapper = styled.div`
+  z-index: var(--z-index-hidden);
+`;
+```
+
 ### Styled from @channel.io/bezier-react to styled-components
 
 **`v2-styled-to-styled-components`**

packages/bezier-codemod/src/App.tsx

@@ -31,6 +31,7 @@ import styledToStyledComponents from './transforms/v2-import-styled-from-styled-
 import inputInterpolationToCssVariable from './transforms/v2-input-interpolation-to-css-variable/transform.js'
 import removeAlphaFromAlphaStack from './transforms/v2-remove-alpha-from-alpha-stack/transform.js'
 import typographyInterpolationToCssVariable from './transforms/v2-typography-interpolation-to-css-variable/transform.js'
+import zIndexInterpolationToCssVariable from './transforms/v2-z-index-interpolation-to-css-variable/transform.js'
 
 enum Step {
   SelectTransformer,
@@ -52,7 +53,8 @@ enum Option {
   V2InputInterpolationToCssVariable = 'v2-input-interpolation-to-css-variable',
   V2TypographyInterpolationToCssVariable = 'v2-typography-interpolation-to-css-variable',
   V2StyledToStyledComponents = 'v2-styled-to-styled-components',
-  V2RemoveAlphaFromAlphaStack = 'remove-alpha-from-alpha-stack',
+  V2RemoveAlphaFromAlphaStack = 'v2-remove-alpha-from-alpha-stack',
+  V2ZIndexInterpolationToCssVariable = 'v2-z-index-interpolation-to-css-variable',
   Exit = 'Exit',
 }
 
@@ -72,6 +74,7 @@ const transformMap = {
   [Option.V2TypographyInterpolationToCssVariable]: typographyInterpolationToCssVariable,
   [Option.V2StyledToStyledComponents]: styledToStyledComponents,
   [Option.V2RemoveAlphaFromAlphaStack]: removeAlphaFromAlphaStack,
+  [Option.V2ZIndexInterpolationToCssVariable]: zIndexInterpolationToCssVariable,
 }
 
 const options = (Object.keys(transformMap) as Option[]).map((transformName) => ({

packages/bezier-codemod/src/shared/enum.ts

@@ -0,0 +1,40 @@
+import {
+  type SourceFile,
+  SyntaxKind,
+} from 'ts-morph'
+
+import { renameEnumMember } from '../utils/enum.js'
+import { hasNamedImportInImportDeclaration } from '../utils/import.js'
+
+type Name = string
+type Member = string
+type Value = string
+export type EnumTransformMap = Record<Name, Record<Member, Value>>
+
+export const transformEnumMemberToStringLiteral = (sourceFile: SourceFile, enumTransforms: EnumTransformMap) => {
+  const transformedEnumNames: string[] = []
+
+  Object
+    .keys(enumTransforms)
+    .forEach((enumName) => {
+      if (hasNamedImportInImportDeclaration(sourceFile, enumName, '@channel.io/bezier-react')) {
+        sourceFile
+          .getDescendantsOfKind(SyntaxKind.PropertyAccessExpression)
+          .filter((node) => node.getFirstChildByKind(SyntaxKind.Identifier)?.getText() === enumName)
+          .forEach((node) => {
+            const enumValue = node.getLastChildByKind(SyntaxKind.Identifier)?.getText()
+            if (enumValue) {
+              renameEnumMember(node, enumTransforms[enumName][enumValue])
+              transformedEnumNames.push(enumName)
+            }
+          })
+      }
+    })
+
+  if (transformedEnumNames.length > 0) {
+    sourceFile.fixUnusedIdentifiers()
+    return true
+  }
+
+  return undefined
+}

packages/bezier-codemod/src/transforms/enum-member-to-string-literal/transform.ts

@@ -1,65 +1,24 @@
-import {
-  Node,
-  type SourceFile,
-  SyntaxKind,
-} from 'ts-morph'
-
-type EnumTransforms = Record<string, Record<string, string>>
-
-function transformEnumMemberToStringLiteral(sourceFile: SourceFile, enumTransforms: EnumTransforms) {
-  const transformedEnumNames: string[] = []
-
-  sourceFile.forEachDescendant((node) => {
-    if (node.isKind(SyntaxKind.PropertyAccessExpression)) {
-      const firstIdentifier = node.getFirstChildByKind(SyntaxKind.Identifier)
-      const lastIdentifier = node.getLastChildByKind(SyntaxKind.Identifier)
-
-      if (firstIdentifier && lastIdentifier) {
-        const declarationSymbol = firstIdentifier.getSymbol()
-        const memberSymbol = lastIdentifier.getSymbol()
-        const memberValueDeclaration = memberSymbol?.getValueDeclaration()
+import { type SourceFile } from 'ts-morph'
 
-        if (Node.isEnumMember(memberValueDeclaration)) {
-          const enumName = declarationSymbol?.getName()
-          const enumMember = memberSymbol?.getName()
-
-          if (enumName && enumMember) {
-            const newEnumMemberValue = enumTransforms[enumName][enumMember]
-            const ancestor = node.getFirstAncestor()
-            if (ancestor?.isKind(SyntaxKind.JsxExpression)) {
-              ancestor.replaceWithText(`'${newEnumMemberValue}'`)
-            } else {
-              node.replaceWithText(`'${newEnumMemberValue}'`)
-            }
-
-            transformedEnumNames.push(enumName)
-          }
-        }
-      }
-    }
-  })
-
-  if (transformedEnumNames.length > 0) {
-    sourceFile.fixUnusedIdentifiers()
-    return true
-  }
-
-  return undefined
+import {
+  type EnumTransformMap,
+  transformEnumMemberToStringLiteral,
+} from '../../shared/enum.js'
+
+const ENUM_TRANSFORM_MAP: EnumTransformMap = {
+  ProgressBarSize: {
+    M: 'm',
+    S: 's',
+  },
+  ProgressBarVariant: {
+    Green: 'green',
+    GreenAlt: 'green-alt',
+    Monochrome: 'monochrome',
+  },
 }
 
 function enumMemberToStringLiteral(sourceFile: SourceFile): true | void {
-  const enumTransforms: EnumTransforms = {
-    ProgressBarSize: {
-      M: 'm',
-      S: 's',
-    },
-    ProgressBarVariant: {
-      Green: 'green',
-      GreenAlt: 'green-alt',
-      Monochrome: 'monochrome',
-    },
-  }
-  return transformEnumMemberToStringLiteral(sourceFile, enumTransforms)
+  return transformEnumMemberToStringLiteral(sourceFile, ENUM_TRANSFORM_MAP)
 }
 
 export default enumMemberToStringLiteral

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-enum-as-prop.input.tsx

@@ -0,0 +1,9 @@
+import { Overlay, ZIndex } from '@channel.io/bezier-react'
+
+export function SelectionOverlay () {
+  return (
+    <Overlay
+      container={{ style: { zIndex: ZIndex.Overlay } }}
+    />
+  )
+}

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-enum-as-prop.output.tsx

@@ -0,0 +1,9 @@
+import { Overlay } from '@channel.io/bezier-react'
+
+export function SelectionOverlay () {
+  return (
+    <Overlay
+      container={{ style: { zIndex: 'var(--z-index-overlay)' } }}
+    />
+  )
+}

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-enum-not-from-bezier-react.input.tsx

@@ -0,0 +1,5 @@
+import { ZIndex } from 'some-library'
+
+export const OVERLAY_POSITION1 = {
+  zIndex: ZIndex.Modal,
+}

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-enum-not-from-bezier-react.output.tsx

@@ -0,0 +1,5 @@
+import { ZIndex } from 'some-library'
+
+export const OVERLAY_POSITION1 = {
+  zIndex: ZIndex.Modal,
+}

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-enum.input.tsx

@@ -0,0 +1,17 @@
+import { ZIndex  } from "@channel.io/bezier-react"
+
+export const OVERLAY_POSITION1 = {
+  zIndex: ZIndex.Modal,
+}
+
+export const OVERLAY_POSITION2 = {
+  zIndex: ZIndex.Float,
+}
+
+export const OVERLAY_POSITION3 = {
+  zIndex: ZIndex.Important,
+}
+
+export const OVERLAY_POSITION4 = {
+  zIndex: ZIndex.Hide,
+}

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-enum.output.tsx

@@ -0,0 +1,16 @@
+
+export const OVERLAY_POSITION1 = {
+  zIndex: 'var(--z-index-modal)',
+}
+
+export const OVERLAY_POSITION2 = {
+  zIndex: 'var(--z-index-float)',
+}
+
+export const OVERLAY_POSITION3 = {
+  zIndex: 'var(--z-index-important)',
+}
+
+export const OVERLAY_POSITION4 = {
+  zIndex: 'var(--z-index-hidden)',
+}

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-interpolation-in-styled-component.input.tsx

@@ -0,0 +1,21 @@
+import { ZIndex, styled } from "@channel.io/bezier-react";
+
+const Wrapper = styled.div`
+  z-index: ${ZIndex.Hide}
+`
+
+const Wrapper = styled.div`
+  z-index: ${ZIndex.Base};
+`
+
+const Wrapper = styled.div`
+  z-index: ${ZIndex.Float};
+`
+
+const Wrapper = styled.div`
+  z-index: ${ZIndex.Tooltip}
+`
+
+const Wrapper = styled.div`
+  z-index: ${ZIndex.Important}
+`

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/fixtures/z-index-interpolation-in-styled-component.output.tsx

@@ -0,0 +1,21 @@
+import { styled } from "@channel.io/bezier-react";
+
+const Wrapper = styled.div`
+  z-index: var(--z-index-hidden);
+`
+
+const Wrapper = styled.div`
+  z-index: var(--z-index-base);
+`
+
+const Wrapper = styled.div`
+  z-index: var(--z-index-float);
+`
+
+const Wrapper = styled.div`
+  z-index: var(--z-index-tooltip);
+`
+
+const Wrapper = styled.div`
+  z-index: var(--z-index-important);
+`

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/transform.test.ts

@@ -0,0 +1,21 @@
+import { testTransformFunction } from '../../utils/test.js'
+
+import interpolationTransform from './transform.js'
+
+describe('z-index interpolation transform', () => {
+  it('should transform z-index interpolation to css variable in styled-component', () => {
+    testTransformFunction(__dirname, 'z-index-interpolation-in-styled-component', interpolationTransform)
+  })
+
+  it('should transform z-index enum to css variable', () => {
+    testTransformFunction(__dirname, 'z-index-enum', interpolationTransform)
+  })
+
+  it('should transform z-index enum to css variable when used as prop', () => {
+    testTransformFunction(__dirname, 'z-index-enum-as-prop', interpolationTransform)
+  })
+
+  it('should not transform z-index enum if it is not imported from bezier-react', () => {
+    testTransformFunction(__dirname, 'z-index-enum-not-from-bezier-react', interpolationTransform)
+  })
+})

packages/bezier-codemod/src/transforms/v2-z-index-interpolation-to-css-variable/transform.ts

@@ -0,0 +1,44 @@
+/* eslint-disable no-template-curly-in-string */
+import { type SourceFile } from 'ts-morph'
+
+import { transformEnumMemberToStringLiteral } from '../../shared/enum.js'
+import { interpolationTransform } from '../../shared/interpolation.js'
+import { removeUnusedNamedImport } from '../../utils/import.js'
+
+const cssVariableByInterpolation = {
+  'ZIndex.Hide': 'var(--z-index-hidden);',
+  'ZIndex.Auto': 'var(--z-index-auto);',
+  'ZIndex.Base': 'var(--z-index-base);',
+  'ZIndex.Float': 'var(--z-index-float);',
+  'ZIndex.Overlay': 'var(--z-index-overlay);',
+  'ZIndex.Modal': 'var(--z-index-modal);',
+  'ZIndex.Toast': 'var(--z-index-toast);',
+  'ZIndex.Tooltip': 'var(--z-index-tooltip);',
+  'ZIndex.Important': 'var(--z-index-important);',
+}
+
+const replaceZIndexInterpolation = (sourceFile: SourceFile) => {
+  const oldSourceFileText = sourceFile.getText()
+
+  interpolationTransform(sourceFile, cssVariableByInterpolation)
+  transformEnumMemberToStringLiteral(sourceFile, {
+    ZIndex: {
+      Hide: 'var(--z-index-hidden)',
+      Base: 'var(--z-index-base)',
+      Float: 'var(--z-index-float)',
+      Overlay: 'var(--z-index-overlay)',
+      Modal: 'var(--z-index-modal)',
+      Toast: 'var(--z-index-toast)',
+      Tooltip: 'var(--z-index-tooltip)',
+      Important: 'var(--z-index-important)',
+    },
+  })
+
+  const isChanged = sourceFile.getText() !== oldSourceFileText
+  if (isChanged) {
+    removeUnusedNamedImport(sourceFile)
+  }
+  return isChanged
+}
+
+export default replaceZIndexInterpolation

packages/bezier-codemod/src/utils/enum.ts

@@ -0,0 +1,14 @@
+import {
+  type PropertyAccessExpression,
+  SyntaxKind,
+} from 'ts-morph'
+
+export const renameEnumMember = (node: PropertyAccessExpression, to: string) => {
+  const ancestor = node.getFirstAncestor()
+
+  if (ancestor?.isKind(SyntaxKind.JsxExpression)) {
+    ancestor.replaceWithText(`'${to}'`)
+  } else {
+    node.replaceWithText(`'${to}'`)
+  }
+}