Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove default value of event handler props #1979

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Feb 6, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Fixes #1122

Summary

Remove default value of event handler props

Details

#1122 를 참고해주세요.

Breaking change? (Yes/No)

No

@sungik-choi sungik-choi added the refactoring Issue or PR related to refactoring with no functional changes label Feb 6, 2024
@sungik-choi sungik-choi self-assigned this Feb 6, 2024
Copy link

changeset-bot bot commented Feb 6, 2024

⚠️ No Changeset found

Latest commit: 54ca380

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3faa301) 84.10% compared to head (54ca380) 84.03%.

Files Patch % Lines
.../bezier-react/src/components/NavGroup/NavGroup.tsx 0.00% 1 Missing ⚠️
...es/bezier-react/src/components/NavItem/NavItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #1979      +/-   ##
==========================================
- Coverage   84.10%   84.03%   -0.08%     
==========================================
  Files         141      141              
  Lines        2277     2267      -10     
  Branches      616      610       -6     
==========================================
- Hits         1915     1905      -10     
  Misses        285      285              
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi merged commit aebd594 into channel-io:alpha Feb 7, 2024
9 of 11 checks passed
@sungik-choi sungik-choi deleted the refactor/rm-noop branch February 7, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issue or PR related to refactoring with no functional changes
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants