Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Syncpack #2027

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Install Syncpack #2027

merged 10 commits into from
Feb 29, 2024

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Feb 27, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

Install Syncpack

Details

  • Downgrade react-textarea-autosize version to 8.3.4 to fix SSR document error #1688, Upgrade dependencies #1997 과 같이 패키지 버전에 의해서 에러가 발생하는 경우를 방지 & 문서화하기 위해 Syncpack을 설치했습니다.
  • 특정 의존성의 버전을 고정(pin)하거나 Semver 기호를 변경할 수 있습니다. 자세한 내용은 공식문서를 참고해주세요.
  • yarn lint 커맨드에 syncpack lint 과정을 포함하여 의도하지 않은 의존성 버전이 설치될 경우 에러를 뱉도록 설정했습니다.
  • 기본적으로 로컬 패키지는 캐럿(^)등의 기호를 사용하지 않도록 설정되어있습니다. npm publish된 패키지에선 문제가 없으나, eslint, tsconfig처럼 로컬에서만 사용하는 패키지에서는 semver를 지정할 경우 npm repository에서 패키지를 검색해서 문제가 발생합니다. 기존처럼 workspace protocol을 사용하도록 설정했습니다.
  • 스토리북 addon-styling의 경우에 버전 정책이 달라 무시하도록 설정했습니다.

Breaking change? (Yes/No)

No

References

@sungik-choi sungik-choi added chore:deps Issue or PR related to dependencies chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code labels Feb 27, 2024
@sungik-choi sungik-choi self-assigned this Feb 27, 2024
Copy link

changeset-bot bot commented Feb 27, 2024

⚠️ No Changeset found

Latest commit: c3afa77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.48%. Comparing base (88c9907) to head (c3afa77).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2027   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         143      143           
  Lines        2588     2588           
  Branches      815      816    +1     
=======================================
  Hits         2264     2264           
  Misses        294      294           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi merged commit 857a20f into channel-io:alpha Feb 29, 2024
11 checks passed
@sungik-choi sungik-choi deleted the chore/syncpack branch February 29, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore:deps Issue or PR related to dependencies chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants