-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(primitives): add storybook documentation #2094
Conversation
|
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2094 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 126 126
Lines 2544 2544
Branches 785 785
=======================================
Hits 2226 2226
+ Misses 312 288 -24
- Partials 6 30 +24 ☔ View full report in Codecov by Sentry. |
37e368d
to
e4e2c29
Compare
@@ -37,7 +38,7 @@ export default { | |||
* `react-docgen-typescript-plugin` introduces significant overhead | |||
* when HMR is enabled, so we enable it only in production. | |||
*/ | |||
reactDocgen: process.env.NODE_ENV === 'production' && 'react-docgen-typescript', | |||
reactDocgen: 'react-docgen-typescript', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
바로 위에 주석도 같이 없어지면 좋을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경사항에 잘못 포함되었네요.. 롤백해두겠습니다
Self Checklist
Summary
Dialog/TooltipPrimitive의 스토리북 문서를 추가합니다.
Details
Breaking change? (Yes/No)
No