Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write mdx documentation for Button component #811

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

inhibitor1217
Copy link
Contributor

Summary

  • 컴포넌트 컨벤션 문서 작성 #705 에서 추가한 컴포넌트 documentation 작성 가이드에 따라, Button 컴포넌트의 documentation을 추가합니다.
  • ButtonOptions interface에 jsdoc을 추가합니다.

Details

  • 스토리북 실행 후 확인하여 첨삭 부탁드립니다!

Browser Compatibility

References

@inhibitor1217 inhibitor1217 added the documentation Issue or PR that improvements or additions to documentation label May 31, 2022
@inhibitor1217 inhibitor1217 self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #811 (535b20d) into next-v1 (7d15371) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           next-v1     #811   +/-   ##
========================================
  Coverage    68.94%   68.94%           
========================================
  Files          204      204           
  Lines         2866     2866           
  Branches       787      787           
========================================
  Hits          1976     1976           
  Misses         775      775           
  Partials       115      115           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d15371...535b20d. Read the comment docs.

@inhibitor1217 inhibitor1217 changed the title Write mdx documentation for Banner component Write mdx documentation for Button component May 31, 2022
@sungik-choi sungik-choi self-requested a review June 22, 2022 05:16
@sungik-choi
Copy link
Contributor

리베이스 후 changeset 추가 부탁드려요!

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

🦋 Changeset detected

Latest commit: 535b20d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inhibitor1217 inhibitor1217 merged commit 61d7569 into channel-io:next-v1 Jul 7, 2022
@inhibitor1217 inhibitor1217 deleted the docs/button branch July 7, 2022 08:30
@sungik-choi sungik-choi mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue or PR that improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants