Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text): add size17 option to Text typography #913

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Aug 17, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • I wrote a unit test about the implementation.
  • I wrote a storybook document about the implementation.
  • I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Fixes #912

Summary

This PR adds Size17 option to Typography

Breaking change or not (Yes/No)

No

References

Figma

@yangwooseong yangwooseong added the enhancement Issues or PR related to making existing features better label Aug 17, 2022
@yangwooseong yangwooseong self-assigned this Aug 17, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

🦋 Changeset detected

Latest commit: 2038b46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #913 (2038b46) into next-v1 (62a4f71) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           next-v1     #913      +/-   ##
===========================================
+ Coverage    70.86%   70.87%   +0.01%     
===========================================
  Files          204      204              
  Lines         2883     2884       +1     
  Branches       797      797              
===========================================
+ Hits          2043     2044       +1     
  Misses         722      722              
  Partials       118      118              
Impacted Files Coverage Δ
packages/bezier-react/src/foundation/Typography.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

@yangwooseong yangwooseong linked an issue Aug 17, 2022 that may be closed by this pull request
@yangwooseong yangwooseong marked this pull request as ready for review August 17, 2022 02:14
Copy link
Contributor

@Seolhun Seolhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트랑 스토리북 문서 작성은 체크리스트에서 제외해야할것 같아요.

@sungik-choi
Copy link
Contributor

테스트랑 스토리북 문서 작성은 체크리스트에서 제외해야할것 같아요.

옵셔널로 두는 건 어떨까요? 체크리스트가 있음으로써 필요성을 환기시켜준다고 생각해서요

@@ -0,0 +1,5 @@
---
"@channel.io/bezier-react": major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 버전과 호환되지 않게 API가 바뀌면 “주(主) 버전”을 올리고,
기존 버전과 호환되면서 새로운 기능을 추가할 때는 “부(部) 버전”을 올리고,
기존 버전과 호환되면서 버그를 수정한 것이라면 “수(修) 버전”을 올린다.

minor나 patch에 가까워보입니다! (fyi https://semver.org/lang/ko/)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇군요..!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 초반에 좀 해매게 되더라고여, ux상 patch가 제일 먼저 나와야되는게 아닌가 싶기도 ㅋㅋ

@Seolhun
Copy link
Contributor

Seolhun commented Aug 17, 2022

테스트랑 스토리북 문서 작성은 체크리스트에서 제외해야할것 같아요.

옵셔널로 두는 건 어떨까요? 체크리스트가 있음으로써 필요성을 환기시켜준다고 생각해서요

제외가 템플릿에서 제외가 아니라, 현재 작업내용에서 체크가 해제 되어야 한다입니다.

@sungik-choi
Copy link
Contributor

테스트랑 스토리북 문서 작성은 체크리스트에서 제외해야할것 같아요.

옵셔널로 두는 건 어떨까요? 체크리스트가 있음으로써 필요성을 환기시켜준다고 생각해서요

제외가 템플릿에서 제외가 아니라, 현재 작업내용에서 체크가 해제 되어야 한다입니다.

아 이해했습니다. 작업내역에 맞게 체크가 되어있을 거라고 상정하고 답했었네요.

@yangwooseong yangwooseong merged commit 38aec7d into channel-io:next-v1 Aug 17, 2022
@yangwooseong yangwooseong deleted the feat/add-size17-to-typo branch August 17, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues or PR related to making existing features better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Size17 to Typography of Text
5 participants