-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(text): add size17 option to Text typography #913
feat(text): add size17 option to Text typography #913
Conversation
🦋 Changeset detectedLatest commit: 2038b46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## next-v1 #913 +/- ##
===========================================
+ Coverage 70.86% 70.87% +0.01%
===========================================
Files 204 204
Lines 2883 2884 +1
Branches 797 797
===========================================
+ Hits 2043 2044 +1
Misses 722 722
Partials 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Chromatic Report🚀 Congratulations! Your build was successful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트랑 스토리북 문서 작성은 체크리스트에서 제외해야할것 같아요.
옵셔널로 두는 건 어떨까요? 체크리스트가 있음으로써 필요성을 환기시켜준다고 생각해서요 |
.changeset/seven-planes-serve.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
"@channel.io/bezier-react": major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존 버전과 호환되지 않게 API가 바뀌면 “주(主) 버전”을 올리고,
기존 버전과 호환되면서 새로운 기능을 추가할 때는 “부(部) 버전”을 올리고,
기존 버전과 호환되면서 버그를 수정한 것이라면 “수(修) 버전”을 올린다.
minor나 patch에 가까워보입니다! (fyi https://semver.org/lang/ko/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그렇군요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 초반에 좀 해매게 되더라고여, ux상 patch가 제일 먼저 나와야되는게 아닌가 싶기도 ㅋㅋ
제외가 템플릿에서 제외가 아니라, |
아 이해했습니다. 작업내역에 맞게 체크가 되어있을 거라고 상정하고 답했었네요. |
Self Checklist
Related Issue
Fixes #912
Summary
This PR adds
Size17
option to TypographyBreaking change or not (Yes/No)
No
References
Figma