Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepend_unique_path test on Windows #1

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Fix prepend_unique_path test on Windows #1

merged 1 commit into from
Feb 7, 2022

Conversation

dmartin
Copy link

@dmartin dmartin commented Feb 7, 2022

Fixes the prepend_unique_path test on Windows targets by using env::join_paths to construct multi-part paths.

This ensures that the Windows path separator (;) is used when necessary, rather than hardcoding Unix-style : separators into the test strings.

@dmartin dmartin mentioned this pull request Feb 7, 2022
Merged
chansuke
chansuke approved these changes Feb 7, 2022
View reviewed changes
Copy link
Owner

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmartin Thank you so much<3

@chansuke chansuke merged commit 62706f5 into chansuke:issue-2848 Feb 7, 2022
@dmartin dmartin deleted the path-fix branch February 7, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chansuke chansuke chansuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmartin @chansuke