Axe context #98
Merged
Axe context #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booc0mtaco
approved these changes
Jul 25, 2024
| * @see https://www.deque.com/axe/core-documentation/api-documentation/#context-parameter | ||
| */ | ||
| get context() { | ||
| return this.parameters.context; |
There was a problem hiding this comment.
Not sure if this is checked elsewhere, but is .parameters guaranteed to exist here? (assuming typescript would be complaining if not)
There was a problem hiding this comment.
Yeah, it's initialized in this object's constructor
ahuth
commented
Jul 25, 2024
Comment on lines
+47
to
+49
| context: normalizeContext(rawStory.parameters?.axe?.context, rawStory) as | ||
| | Context | ||
| | undefined, |
There was a problem hiding this comment.
Note the as. I didn't feel like creating a Zod schema for all the permutations the context object can take, so left it just checking the general shape.
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter for Axe context. #53
Useful for excluding parts of the page.