Skip to content

Commit

Permalink
chore: move curated lists to ontology-assets (#48)
Browse files Browse the repository at this point in the history
## Reason for Change

- preparing the repo for automated data releases.
- moving the assets that will be part of ontology asset release to thier
own directly make it easier to added them to a release.

## Changes

- update validator to look for curated lists in ontology-assets
- move curated lists to ontology-assets

## Testing steps

- Check that GHA validate curated lists passes
- Check that unit tests pass.
  • Loading branch information
Bento007 authored Feb 26, 2024
2 parents 3121833 + 66476d4 commit 77916df
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/validate_curated_lists.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Validate Curated List Update
on:
push:
paths:
- "**/tools/ontology-builder/src/ontology-references/**.json"
- "**/ontology-assets/**.json"
- "**/artifact-schemas/**.json"
branches-ignore:
- main
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 3 additions & 1 deletion tools/ontology-builder/src/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@
RAW_ONTOLOGY_DIR = os.path.join(ONTOLOGY_REF_DIR, "raw-files")
ONTO_INFO_YAML = os.path.join(FIXTURES_ROOT, "ontology_info.yml")
PARSED_ONTOLOGIES_FILE = os.path.join(FIXTURES_ROOT, "all_ontology.json.gz")
SCHEMA_DIR = os.path.join(os.path.realpath(__file__).rsplit("/", maxsplit=4)[0], "artifact-schemas")
PROJECT_ROOT_DIR = os.path.realpath(__file__).rsplit("/", maxsplit=4)[0]
SCHEMA_DIR = os.path.join(PROJECT_ROOT_DIR, "artifact-schemas")
ONTOLOGY_ASSETS_DIR = os.path.join(PROJECT_ROOT_DIR, "ontology-assets")
2 changes: 1 addition & 1 deletion tools/ontology-builder/src/validate_curated_lists.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def verify_json(schema_file_name: str, json_file_name: str) -> bool:
return True


def main(path: str = env.ONTOLOGY_REF_DIR) -> None:
def main(path: str = env.ONTOLOGY_ASSETS_DIR) -> None:
"""
Verify the curated JSON lists match their respective JSON schema in artifact-schemas
:param path: The destination path for the json files
Expand Down

0 comments on commit 77916df

Please sign in to comment.