Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): The API downloads the Data Release during or after install. #13

Closed
Bento007 opened this issue Feb 9, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@Bento007
Copy link
Collaborator

Bento007 commented Feb 9, 2024

Need:

To streamline integration across products, the latest compatible data release is installed when the API is installed. This makes it easier for other services to stay up to date on the latest ontology without making changes to their code.

The package should also remain performant and compact. After downloading the JSON data release, convert it into a more python native file format.

Depends_on:

  • Create a first release
    • For testing the full functionality.

DOD:

  • The API must be aware of what version of the Data Release it is compatible with. When downloading the Data Release, only download the latest compatible version.
  • Only download the Data Release once, and cache the files locally for future use.
  • Implement fetching source repos + version tags from API + Tests
  • Can also run off a local all_ontology.json
  • Can pin to a specific data release.
  • Covert to python native file format Example: pickle
  • Delete remove original JSON.
@nayib-jose-gloria
Copy link
Collaborator

Changes to this ticket: Decided to implement such that we do NOT download a data version upon install; instead, users create an OntologyParser object for the schema_version they want to use ontology files for, and we will fetch + load that in-memory. Did not implement pickling (though we may revisit that decision in a future ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants