feat: Add dimension selector tool palette at bottom of screen #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankmartin
reviewed
Jan 15, 2025
| @@ -291,6 +293,17 @@ def combine_json_layers( | |||
| "row": 2, | |||
| "visible": False, | |||
| }, | |||
| "toolPalettes": { | |||
There was a problem hiding this comment.
There are a few changes which would be helpful here! The first is to have it stack horizontally, which would be controlled by "verticalStacking". The second is to make this a query, because that way the user can't delete the controls.
Something like
"toolPalettes": {
"Palette": {
"side": "bottom",
"row": 1,
"size": 120,
"query": "type:dimension",
"verticalStacking": false
}
}
The size would depend on whether it is vertically or horizontally stacked to be honest, but let's try this size for now.
| def test__generate_configuration_default_values(): | ||
| state = combine_json_layers(layers=[{"type": "image", "volumeRendering": "OK", "name": "myname"}], scale=1.0) | ||
|
|
||
| assert "enableLayerColorWidget" in state |
There was a problem hiding this comment.
In this case I think we'll need to pull out the color widget related changes, because I don't think we can merge this PR until horizontal stacking and our scroll fix are available. Unlike some of the other changes which can sit in the state and wait until neuroglancer understands the state changes
seankmartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CC-203