Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ML Challenge banner #1457

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update ML Challenge banner #1457

wants to merge 10 commits into from

Conversation

bchu1
Copy link
Contributor

@bchu1 bchu1 commented Jan 10, 2025

#1440

This should be merged right before 1/15.

Makes some code simplifications:

  • Removes timer logic. We can just make the changes manually before the dates when the banner needs to be updated. This is so we have more testability and control over the code. Product also did not request any countdown text in the final copy.
  • Removes usage of poorly documented third party hook, just uses localStorage directly.
  • Switches from using 1 localStorage key to keep track of the last dismissed banner version to using separate keys for each banner version.

There's an unrelated test failure due to a current mismatch in BE staging data between V1 and V2.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Frontend Preview URL

https://bchu-banner.cryoet.dev.si.czi.technology

Updated: 01/10/25 @ 12:07:43 PM PST

@bchu1 bchu1 changed the title feat: Update ML Challenge banner Update ML Challenge banner Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant