Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade next #869

Merged
merged 1 commit into from
Dec 15, 2021
Merged

upgrade next #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/frontend/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/// <reference types="next" />
/// <reference types="next/types/global" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little confusing to tell from the docs but this file is regenerated when you run next build, i think it removed that line because that next type is no longer relevant to the typescript compiler with the upgrade

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just needed to docker-compose down then up the containers -- also ran a DB migration, but I don't think that matters -- and this line re-appeared in my next-env.d.ts file.

/// <reference types="next/types/global" />

Maybe we should re-commit it back in? Probably has no impact on how it runs since we build during the CI pipeline, but if it keeps showing up as a dirty file locally that will just be confusing to see.

/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
Expand Down
Loading