Re-Attach to running alignment chunks on retry #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through a few iterations of this but I think the simplest way is to base the approach on a cache. We don't want to make the same batch call twice. The first batch call puts a job on the spot queue, the second the on-demand queue. Also if for whatever reason we change the job definition or inputs that is also part of the cache key.
I also added the convention of adding the tag
AlignmentCoordination=Trueto these files so we can clean them with a lifecycle policy. More for cleanliness than cost. I am not sure what convention you are using. Does this make sense @rzlim08 ?