Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprected tokens #1752

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

we deprecated these inconsistent tokens from the library, but they were remaining in the page demo. Remove them to avoid any confusion

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • make sure no snapshots change

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1752 (ed725a7) into next (4c8091d) will not change coverage.
Report is 1 commits behind head on next.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1752   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         146      146           
  Lines        2580     2580           
  Branches      665      665           
=======================================
  Hits         2381     2381           
  Misses        183      183           
  Partials       16       16           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

size-limit report 📦

Path Size
components 95.29 KB (0%)
styles 32.77 KB (0%)

@booc0mtaco booc0mtaco requested a review from a team September 12, 2023 18:43
@booc0mtaco booc0mtaco merged commit 5e388fa into next Sep 12, 2023
8 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-remove-deprecated-wireframe-tokens branch September 12, 2023 19:33
@booc0mtaco booc0mtaco mentioned this pull request Sep 22, 2023
booc0mtaco added a commit that referenced this pull request Sep 22, 2023
## [13.3.0](v13.2.0...v13.3.0) (2023-09-22)


### Features

* add event hooks to existing components ([#1757](#1757)) ([9045cf5](9045cf5))
* **Icons:** add 'edit' icon to spritemap ([#1760](#1760)) ([f56983a](f56983a))
* **Select:** add warning when name is missing from component props ([#1756](#1756)) ([e3f2bc1](e3f2bc1))


### Bug Fixes

* remove deprecated tokens from wireframe page ([#1752](#1752)) ([5e388fa](5e388fa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants