feat(Icons): add 'edit' icon to spritemap #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1760 +/- ##
==========================================
- Coverage 92.22% 92.19% -0.03%
==========================================
Files 146 146
Lines 2584 2588 +4
Branches 664 666 +2
==========================================
+ Hits 2383 2386 +3
- Misses 200 201 +1
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
size-limit report 📦
|
|
|
Sadly, it looks like the names between design and eng are not in sync, so there will be some follow up work to name them similarly, and to add any missing ones where they belong. |
jeremiah-clothier
approved these changes
Sep 19, 2023
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 22, 2023
## [13.3.0](v13.2.0...v13.3.0) (2023-09-22) ### Features * add event hooks to existing components ([#1757](#1757)) ([9045cf5](9045cf5)) * **Icons:** add 'edit' icon to spritemap ([#1760](#1760)) ([f56983a](f56983a)) * **Select:** add warning when name is missing from component props ([#1756](#1756)) ([e3f2bc1](e3f2bc1)) ### Bug Fixes * remove deprecated tokens from wireframe page ([#1752](#1752)) ([5e388fa](5e388fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is added to sync with one mentioned in the foundation sprite sheet
Test Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.