feat(Select): add warning when name is missing from component props #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1756 +/- ##
==========================================
- Coverage 92.28% 92.22% -0.07%
==========================================
Files 146 146
Lines 2580 2584 +4
Branches 665 664 -1
==========================================
+ Hits 2381 2383 +2
- Misses 183 200 +17
+ Partials 16 1 -15
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
size-limit report 📦
|
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 22, 2023
## [13.3.0](v13.2.0...v13.3.0) (2023-09-22) ### Features * add event hooks to existing components ([#1757](#1757)) ([9045cf5](9045cf5)) * **Icons:** add 'edit' icon to spritemap ([#1760](#1760)) ([f56983a](f56983a)) * **Select:** add warning when name is missing from component props ([#1756](#1756)) ([e3f2bc1](e3f2bc1)) ### Bug Fixes * remove deprecated tokens from wireframe page ([#1752](#1752)) ([5e388fa](5e388fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There have been a few recent cases where
Selectpresented problems for consumers. Namely, certain frameworks expect a form field to appear so that data can be submitted (no pun intended). This is an important behavior, and luckily HeadlessUI supports this in the underlyingListboxcomponent.Add some documentation to explain this, and a dev-time warning to double-down on the recommendation. In the future,
namemay be a required prop when using any/all form elements.Test Plan:
Wroteupdated automated testsedu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.