Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update prettier #1714

Merged
merged 2 commits into from
Aug 7, 2023
Merged

chore(deps): update prettier #1714

merged 2 commits into from
Aug 7, 2023

Conversation

czi-developer-foundations
Copy link
Collaborator

@czi-developer-foundations czi-developer-foundations commented Jul 31, 2023

This PR contains the following updates:

Package Type Change
@chanzuckerberg/prettier-config-edu (source) devDependencies ^1.0.4 -> ^1.0.5
eslint-config-prettier devDependencies ^8.7.0 -> ^8.10.0
prettier (source) devDependencies ^2.8.4 -> ^2.8.8

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1714 (9480a8a) into next (d8a4f6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1714   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         146      146           
  Lines        2579     2579           
  Branches      664      664           
=======================================
  Hits         2380     2380           
- Misses        183      198   +15     
+ Partials       16        1   -15     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

size-limit report 📦

Path Size
components 95.49 KB (0%)
styles 32.76 KB (0%)

@booc0mtaco
Copy link
Contributor

@ahuth weird, did we change the rules in our config and that's causing the build to fail here? the changelog for our package doesn't show it 🤔

@ahuth
Copy link
Contributor

ahuth commented Aug 7, 2023

My guess is the Prettier version bump changed how it formatted some things.

I'd run lint --fix and commit the new formatting

Copy link
Contributor

@ahuth ahuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Forgot to mention earlier, we may want to upgrade Prettier to v3 at some point, which may require us to move off of the shared edu prettier config (since its recent versions are not published on npm). I just had to do this for axe-storybook-testing.

@booc0mtaco booc0mtaco merged commit 3288ba4 into next Aug 7, 2023
@booc0mtaco booc0mtaco deleted the renovate/prettier branch August 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants