Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deploy docs for storybook 7.x #1733

Merged
merged 3 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,29 +1,35 @@
name: Deploy Docs
name: Deploy Docs to GH Pages

on:
push:
branches:
- main

jobs:
deploy_docs:
deploy:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Setup node 😻
uses: actions/setup-node@v3
with:
- name: Checkout code
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: '.node-version'
cache: 'yarn'

- name: Install Dependencies ⬆️
run: yarn install --immutable
- name: Install Dependencies
run: yarn install --immutable

- name: Build EDS
run: yarn build

- name: Build Dist 🔧
run: yarn run build
- name: Build Storybook
run: yarn build:storybook

- name: Deploy Storybook Docs 🚀
run: yarn run deploy:docs
env:
GH_TOKEN: '${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}'
- name: Deploy Storybook
uses: peaceiris/actions-gh-pages@v3
with:
publish_dir: ./storybook-static
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the naming is a bit awkward here... this should be read as dir_to_publish or similar; this isn't where the docs will be published to, and won't end up in the path

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"chromatic": "chromatic",
"copy-fonts-to-lib": "copyfiles -u 3 src/design-tokens/tier-1-definitions/fonts.css src/design-tokens/tier-1-definitions/fonts/**/* lib/tokens",
"create-component": "plop",
"deploy:docs": "storybook-to-ghpages --ci",
"lint": "yarn run lint:styles && yarn run lint:scripts",
"lint:fix": "yarn run lint:styles:fix && yarn run lint:scripts:fix",
"lint:styles": "stylelint --ignore-path .gitignore src/**/*.css .storybook/**/*.css",
Expand Down Expand Up @@ -123,7 +122,6 @@
"@storybook/addon-styling": "^1.3.6",
"@storybook/react": "^7.3.1",
"@storybook/react-webpack5": "^7.3.1",
"@storybook/storybook-deployer": "^2.8.16",
"@storybook/testing-library": "^0.2.0",
"@storybook/testing-react": "^2.0.1",
"@testing-library/jest-dom": "^5.17.0",
Expand Down
Loading
Loading