Generate valid tab ids #1737
Merged
Generate valid tab ids #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuth
force-pushed
the
ah-tab-ids
branch
2 times, most recently
from
4836a07
to
f56027c
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1737 +/- ##
==========================================
- Coverage 92.32% 92.28% -0.04%
==========================================
Files 146 146
Lines 2579 2580 +1
Branches 665 665
==========================================
Hits 2381 2381
Misses 183 183
- Partials 15 16 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andremalan
approved these changes
Aug 31, 2023
booc0mtaco
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noted in https://czi-edu.slack.com/archives/CTFV79JH4/p1693505461086869, we're generating invalid ids for tabs. Here we fix that.
Test Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.