Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add plugin for intellisense of css variables #1748

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

jeremiah-clothier
Copy link
Contributor

@jeremiah-clothier jeremiah-clothier commented Sep 7, 2023

Summary:

There are soo many CSS variables in EDS it's hard to know what the values are when looking at a .module.css file. I'm adding the "CSS Var Complete" extension to help get some IntelliSense when working in .module.css files.

Test Plan:

  • Manually testing experience with this plugin (before and after)

Before
image
image

After

Better IntelliSense and values are rendered as you hover over them

image
image

@jeremiah-clothier jeremiah-clothier requested review from booc0mtaco and a team September 7, 2023 20:42
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

size-limit report 📦

Path Size
components 95.29 KB (0%)
styles 32.77 KB (0%)

@jeremiah-clothier
Copy link
Contributor Author

@booc0mtaco It doesn't work great with nested values
image

@booc0mtaco
Copy link
Contributor

@jeremiah-clothier This is great! I think something like this would also be useful in our stack and various projects. I will think about where and how to document that (if nothing else, can be part of the stack and patched into current point solutions)

@jeremiah-clothier
Copy link
Contributor Author

@jeremiah-clothier This is great! I think something like this would also be useful in our stack and various projects. I will think about where and how to document that (if nothing else, can be part of the stack and patched into current point solutions)

We had this in the Learning Platform, here's where I documented that. Although documentation closer to the repo may be better. https://czi.atlassian.net/wiki/spaces/ETE/pages/2689335723/Visual+Studio+Code+Setup#EDS-Intellisense

@booc0mtaco
Copy link
Contributor

@jeremiah-clothier good link, thanks :) I'll add it to the dev docs here, as anyone outside the org would also benefit from such setup info

Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremiah-clothier for using this plugin, are there any manual steps an engineer would need to follow? if so, can you include a little text for EDS local setup in CONTRIBUTING.md?

@booc0mtaco
Copy link
Contributor

@jeremiah-clothier actually it's probably good to merge this as-is, and we can do any question-answering as it comes up

@jeremiah-clothier
Copy link
Contributor Author

@jeremiah-clothier actually it's probably good to merge this as-is, and we can do any question-answering as it comes up

Oh whoops, let me add some blurb to the docs

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1748 (079a038) into next (91497bf) will not change coverage.
Report is 4 commits behind head on next.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1748   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         146      146           
  Lines        2580     2580           
  Branches      665      665           
=======================================
  Hits         2381     2381           
  Misses        183      183           
  Partials       16       16           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeremiah-clothier jeremiah-clothier merged commit b30907e into next Sep 12, 2023
8 checks passed
@jeremiah-clothier jeremiah-clothier deleted the jclothier/dev-ex branch September 12, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants