Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tag)!: remove deprecated props and update API #1862

Merged
merged 1 commit into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. feat(Tag)!: remove deprecated props and update API

    - remove deprecated value "yield" from variant list
    
    We had both "warning" and "yield" as possible values for this
    component's variants, which was confusing. Going forward, we will start
    with just "warning", and remove this option from the component list. If
    using "yield", please consider using "warning" instead, or some other
    treatment.
    
    - change "icon" prop to be of type `IconName` to be consistent with all
      other components
    
    This syncs up the headless Icon handling across all components, meaning
    that the names and possible values are determined by the mapped icons,
    and not any possible ReactNode instance. For consumers, replace any
    usages of `<Icon />` with the string provided to this cmoponent. Any
    other nodes used will have to be removed.
    
    - tidy up usage of `<Text />` and typography handling
    
    simplify the handling of type in this component by moving to use
    `preset` instead of the more `<font>` like weight and size props, which
    will also be removed.
    
    - update tests, snapshots, and usages.
    booc0mtaco committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e08d2eb View commit details
    Browse the repository at this point in the history