feat(Link)!: introduce v2.0 component

[booc0mtaco]

• add stories and styles to match new design
• update snapshots

Test Plan:

• Wrote automated tests
• CI tests / new tests are not applicable
• Manually tested my changes, but I want to keep the details secret
• Created and used an alpha publish
• Manually tested my changes, and here are the details:

[codecov]

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 96.63%. Comparing base (d5782cd) to head (fb56ee0).
Report is 3 commits behind head on v15-components-2.0.

Files	Patch %	Lines
src/components/Link/Link-v2.tsx	31.57%	13 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           v15-components-2.0    #1890      +/-   ##
======================================================
- Coverage               97.16%   96.63%   -0.53%     
======================================================
  Files                     106      107       +1     
  Lines                    2330     2350      +20     
  Branches                  546      556      +10     
======================================================
+ Hits                     2264     2271       +7     
- Misses                     64       77      +13     
  Partials                    2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[booc0mtaco]

Adding this to support links link in Remix. Will likely need some work to support fully, but will be able to test once i get thru the first wave of component implementations

[ahuth]

Challenge I see: Remix links currently use to instead of href

So to enable passing in a Remix link to here, we'd probably need to figure out how to support passing the EDS Link's href prop to the Remix Link's to somehow.

[booc0mtaco]

I want to replicate what we do using ClickableStyle and also get rid of that component in the next version :).

I didn't want to copy how ClickableStyle works in here, b/c it seems to lose all the typing information and converts everything to any :( What does make sense over there is that it uses a type param to combine the types of Remix's Link with the component props.

I'm guessing this was part of why you needed to export the types earlier?

[ahuth]

I agree on that goal, and not wanting to do ClickableStyle.

My point is that to achieve:

<EdsLink
  as={RemixLink}
  href={...} // or maybe to={...}?
/>

we'll need to figure out how to handle href vs to.

[ahuth]

One way to do that would be for the Eds Link to take href and always pass both it as both href and to on to the as component...

Kind of annoying, but that's the simplest thing I can see (at least until Remix updates its Link to use the standard href).

[booc0mtaco]

I agree on that goal, and not wanting to do ClickableStyle.

My point is that to achieve:

<EdsLink
  as={RemixLink}
  href={...} // or maybe to={...}?
/>

we'll need to figure out how to handle href vs to.

Yah, I think you misunderstood. The way ClickableStyle supports to/href is weird, but "works". So we are saying the same thing basically.

I want to avoid polluting EDS with anything specific to Remix or some other framework, as well. I like the TypeParam approach (e.g., combine EDSLink with Framework type, with option or to Omit). Once I get thru the re-theming, I'll try a few things.

[ahuth]

Can't wait until React removes forwardRef in React 19

[booc0mtaco]

Ohh, what will happen instead? I never read the upcoming docs for things besides HTML/CSS/JS :P

[ahuth]

What's omitting disabled all about? I thought disabled already wasn't an attribute on anchor elements?

[booc0mtaco]

Good catch, this is probably a carry-over from the ClickableStyles stuff that wasn't removed a while back.

[booc0mtaco]

Will merge this in to the v15 branch, and come back to the handling of router links toward the end of the month. Marking a few things in code so I don't forget first