Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tailwind): update animation token export types #2047

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(tailwind): update animation token export types #2047

merged 1 commit into from
Aug 26, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Aug 26, 2024 •
edited
Loading

  • not giving a type to the data extracted from the internal config results in an any being emitted in the package
  • replace that with a similar form used by sizes

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:
    • tested diff in consuming project

@booc0mtaco booc0mtaco requested a review from a team August 26, 2024 19:03
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
components 89.26 KB (0%)
styles 27.27 KB (0%)

@booc0mtaco booc0mtaco added the bug Something isn't working label Aug 26, 2024
@booc0mtaco booc0mtaco requested review from jeremiah-clothier and a team August 26, 2024 19:28
@booc0mtaco booc0mtaco merged commit 0f95301 into next Aug 26, 2024
9 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-fix-tailwind-config-types branch August 26, 2024 19:30
@booc0mtaco booc0mtaco mentioned this pull request Aug 26, 2024
Merged
booc0mtaco added a commit that referenced this pull request Aug 26, 2024
@booc0mtaco
Merge pull request #2048 from chanzuckerberg/release-v15.3.1
16c2681 
### [15.3.1](v15.3.0...v15.3.1) (2024-08-26)

[Storybook](https://61313967cde49b003ae2a860-jyqlmpntqz.chromatic.com/)

### Bug Fixes

* **tailwind:** update animation token export types ([#2047](#2047)) ([0f95301](0f95301))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuth ahuth ahuth approved these changes

@jeremiah-clothier jeremiah-clothier Awaiting requested review from jeremiah-clothier

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @ahuth