Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DataTable): allow for pinning columns #2084

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat(DataTable): allow for pinning columns #2084

merged 1 commit into from
Nov 5, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Oct 28, 2024 •
edited
Loading

  • first column is pinned by default
  • allow for other columns to be pinned

Remaining

  • fix display of shadows when not needed / scrolled into view
  • fix overlap of rows onto column header
  • make shadow appear dynamically like header

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

size-limit report 📦

Path Size
components 92.84 KB (+0.16% 🔺)
styles 29.03 KB (+0.72% 🔺)

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.02%. Comparing base (1894c2d) to head (9940575).
Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
src/components/DataTable/DataTable.tsx 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2084      +/-   ##
==========================================
- Coverage   97.10%   97.02%   -0.09%     
==========================================
  Files         111      111              
  Lines        2766     2786      +20     
  Branches      738      753      +15     
==========================================
+ Hits         2686     2703      +17     
- Misses         77       79       +2     
- Partials        3        4       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco booc0mtaco force-pushed the aholloway/EDS-1407 branch 2 times, most recently from 4ccef1b to 6abd01a Compare November 4, 2024 23:15
@booc0mtaco booc0mtaco requested a review from a team November 4, 2024 23:20
@booc0mtaco booc0mtaco marked this pull request as ready for review November 4, 2024 23:20
@booc0mtaco
Copy link
Contributor Author

Screen.Recording.2024-11-04.at.17.29.42.mov

@booc0mtaco
feat(DataTable): allow for pinning columns
9940575 
- first column is pinned by default
- allow for other columns to be pinned
- clean up existing stories to fit with design
@ademartini-czi
Copy link

I'm not super knowledgable about this kind of stuff but it looks great!

@booc0mtaco
Copy link
Contributor Author

@ademartini-czi thanks !

@booc0mtaco booc0mtaco merged commit 86d7d07 into next Nov 5, 2024
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1407 branch November 5, 2024 18:12
@booc0mtaco booc0mtaco mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademartini-czi ademartini-czi ademartini-czi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @ademartini-czi