-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve formatting of generated tf code #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
approved these changes
May 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 61.12% 61.22% +0.09%
==========================================
Files 19 19
Lines 1955 1960 +5
==========================================
+ Hits 1195 1200 +5
Misses 607 607
Partials 153 153
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapse all vertical whitespaces (runs of \n) in generated code to reduce the number of whitespace-only diffs that fogg generates.
Post 0.12 the
terraform fmt
command avoids managing vertical whitespace (ie newlines).That decision combined with our use fo go templates, wherein is it at best annoying and at worse impossible to reliably manage vertical whitespace the way we want to means that we havegiven up on avoiding diffs with meaningless whitespace changes.
From here forward we will collapse all \n+ to \n in generated code. This will mostly only affect fogg.tf, which is exactly what we want.
Test Plan
References