Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve File? task output processing #615

Merged
merged 3 commits into from
Nov 22, 2022
Merged

improve File? task output processing #615

merged 3 commits into from
Nov 22, 2022

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 18, 2022

Replace a hack that caused problems (#614) with optional File/Directory outputs, related to when & how a nonexistent output path is changed to None.

@coveralls
Copy link

coveralls commented Nov 18, 2022

Pull Request Test Coverage Report for Build 3507053885

  • 47 of 47 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 95.203%

Files with Coverage Reduction New Missed Lines %
WDL/runtime/backend/docker_swarm.py 1 91.45%
WDL/runtime/task.py 1 95.79%
Totals Coverage Status
Change from base Build 3384709402: -0.02%
Covered Lines: 7224
Relevant Lines: 7588

💛 - Coveralls

@mlin mlin marked this pull request as ready for review November 20, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants