Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-workflows maintenance data fetch cleanup #1148

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Conversation

manasaV3
Copy link
Collaborator

@manasaV3 manasaV3 commented Jul 14, 2023

Description

Relates to #1155, #1157

  • Cleaning up install activity tests
  • Adding tests for maintenance workflow
  • Replacing calls for plugin fetch from s3
  • Removing permissions for s3 read for the data workflow
  • Fixes bug of applying repo_type to all plugins

@manasaV3 manasaV3 added the improvement Release Label: Used for categorizing improvements in automated CI release notes label Jul 14, 2023
@manasaV3 manasaV3 marked this pull request as draft July 14, 2023 18:45
@manasaV3 manasaV3 marked this pull request as ready for review July 17, 2023 18:28
@manasaV3 manasaV3 requested a review from codemonkey800 July 17, 2023 18:29
@manasaV3 manasaV3 changed the title Maintenance cleanup data-workflows maintenance data fetch cleanup Jul 17, 2023
codemonkey800
codemonkey800 previously approved these changes Jul 17, 2023
@manasaV3 manasaV3 merged commit d6f5db8 into main Jul 20, 2023
@manasaV3 manasaV3 deleted the maintenance-cleanup branch July 20, 2023 22:08
joshkmartinez pushed a commit that referenced this pull request Jul 24, 2023
* Cleaning up install activity model

* Replacing s3 calls with plugin table

* Adding unit tests

* Updating case for plugin name

* Removing s3 read permission

* Adding unit test for nhcommons

* Cleaning up GithubActivityTypes

* Adding logging for missing plugin name

* Fixing repo_type bug
@github-actions
Copy link

This PR has been included in release: v23.07.1, see the release notes.

@manasaV3 manasaV3 mentioned this pull request Jul 27, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Release Label: Used for categorizing improvements in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants