Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing backend workflow for writing plugin data to s3 #1204

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

manasaV3
Copy link
Collaborator

@manasaV3 manasaV3 commented Aug 3, 2023

Description

Relates to #1192

  • Removes backend workflow to fetch and write data to s3.
  • Removes other components that are no longer being used.

Notes

  • We should validate that the plugin s3 files are no longer being used before merging this change.

@manasaV3 manasaV3 added the maintenance Release Label: Used for categorizing maintenance PRs in automated CI release notes label Aug 3, 2023
@aganders3
Copy link
Contributor

aganders3 commented Aug 3, 2023

LGTM - I always love to see this kind of +/-!

I notice you removed datadog.py - perhaps this also means you can remove datadog-lambda from requirements.txt. Maybe even remove the whole Dockerfile? It has CMD ["datadog_lambda.handler.handler"] but I'm not sure if it's also used for something else.

Oh I guess also regarding the overall intent - I guess this means the new workflow writing to Dynamo is confirmed working? Is that documented somewhere?

@manasaV3
Copy link
Collaborator Author

manasaV3 commented Aug 3, 2023

I notice you removed datadog.py - perhaps this also means you can remove datadog-lambda from requirements.txt. Maybe even remove the whole Dockerfile? It has CMD ["datadog_lambda.handler.handler"] but I'm not sure if it's also used for something else.

This is a great call out. 😁 As there are some data that the datadog captures such as latency trace for the request, it is beneficial to retain the data-dog component in the Dockerfile for now, this, in turn, requires retaining the datadog-lambda requirement.

Oh I guess also regarding the overall intent - I guess this means the new workflow writing to Dynamo is confirmed working? Is that documented somewhere?

We validated the data being written to Dynamo using feature flags. The front end has been rendering the data from Dynamo for a few weeks. In addition, I also ran some scripts to ascertain the data parity between s3 and dynamo data. 😄

@aganders3
Copy link
Contributor

Nice, thanks! I am a little familiar with DataDog but was not familiar with the lambda wrapper. I see what's happening here now. 😄

@manasaV3 manasaV3 merged commit 20d80c0 into main Aug 8, 2023
@manasaV3 manasaV3 deleted the plugin_workflow_cleanup branch August 8, 2023 00:37
@github-actions
Copy link

This PR has been included in release: v23.08.1, see the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Release Label: Used for categorizing maintenance PRs in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants