Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechnism to ignore commits in release notes #1330

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

aganders3
Copy link
Contributor

Description

The release notes workflow depends on specific commit/PR structures, and is currently broken. This PR adds a mechanism to explicitly ignore certain commits. It also ignores the specific problematic commit.

Ignore 'e5b0a312ddb1d508b2d14b4c101b894f2a4c7356' because it was
committed without a PR.
@aganders3 aganders3 added the cicd Release Label: Used for categorizing CICD changes in automated CI release notes label Jan 7, 2025
@aganders3 aganders3 requested a review from manasaV3 January 7, 2025 17:21
@aganders3
Copy link
Contributor Author

I got impatient and ran the workflow from this branch to test it. It seems to work!
https://github.com/chanzuckerberg/napari-hub/actions/runs/12656760459

Copy link
Collaborator

@richaagarwal richaagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, and sorry for my commit that caused this in the first place 😅

@aganders3 aganders3 merged commit 5fd6464 into main Jan 8, 2025
2 checks passed
@aganders3 aganders3 deleted the fix-release-notes-ignore-commits branch January 8, 2025 17:29
Copy link

This PR has been included in release: v25.01.0, see the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Release Label: Used for categorizing CICD changes in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants