Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[math] Optimize compatible numpy method in brainunit.math #11

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

Routhleck
Copy link
Collaborator

Replace with clearer wrap function

@Routhleck Routhleck marked this pull request as ready for review June 12, 2024 07:58
@Routhleck Routhleck requested a review from chaoming0625 June 12, 2024 07:58
@Routhleck Routhleck changed the title Optimize compatible numpy method in brainunit.math [math] Optimize compatible numpy method in brainunit.math Jun 12, 2024
@Routhleck Routhleck marked this pull request as draft June 12, 2024 07:59
@Routhleck Routhleck marked this pull request as ready for review June 12, 2024 08:00
@Routhleck
Copy link
Collaborator Author

Should wait before #10 merged

@chaoming0625
Copy link
Collaborator

There are some conflicts. Maybe need a manual fix before merging.

@Routhleck
Copy link
Collaborator Author

Conflicts resolved

Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work.

@chaoming0625 chaoming0625 merged commit 470e711 into main Jun 12, 2024
24 checks passed
@chaoming0625 chaoming0625 deleted the update-compat-numpy branch June 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants