Feature/clickhouse connector

[MahmoudElhalwany]

#1085

[netlify]

✅ Deploy Preview for frontend-sb canceled.

Name	Link
🔨 Latest commit	c3f9350
🔍 Latest deploy log	https://app.netlify.com/sites/frontend-sb/deploys/630dec27e7526200089a1c34

[Samyak2]

Hey @MahmoudElhalwany, thank you very much for your contribution! This looks great overall and everything seems to be working (I tested on a local clickhouse set up). The icon is good too.

That said, I had a few comments and questions on the changes. Please find them below.

[Samyak2]

Looks great!

It would be helpful if you could show the error you got when trying the native client. I'll try it from my side too.

[MahmoudElhalwany]

Looks great!

It would be helpful if you could show the error you got when trying the native client. I'll try it from my side too.

Okay, but there is a potential bug too there is some datatypes in ClickHouse not supported in the library and in python like Int128

[Samyak2]

there is some datatypes in ClickHouse not supported in the library and in python like Int128

Looks like there is an open PR for this: xzkostyan/clickhouse-sqlalchemy#184

Is this something that is necessary for your usecase?

---

Did you find any bugs specific to the native interface/connector?

[MahmoudElhalwany]

there is some datatypes in ClickHouse not supported in the library and in python like Int128

Looks like there is an open PR for this: xzkostyan/clickhouse-sqlalchemy#184

Is this something that is necessary for your usecase?

Did you find any bugs specific to the native interface/connector?

@Samyak2
I just have some tables that use Int128 in their columns, it gives me errors when I choose that database when initialization.
for native bugs -- until now, No. So, we can change it to native.
Did you find any bugs using the native ??

[Samyak2]

I just have some tables that use Int128 in their columns, it gives me errors when I choose that database when initialization.

Oh I see. By initialization do you mean adding the data source? Or is this after adding the KPI?

for native bugs -- until now, No. So, we can change it to native.
Did you find any bugs using the native ??

No, the native connector works for me too. Although, I had to change the port to 9000 instead of 8123 for HTTP.

[MahmoudElhalwany]

I just have some tables that use Int128 in their columns, it gives me errors when I choose that database when initialization.

Oh I see. By initialization do you mean adding the data source? Or is this after adding the KPI?

for native bugs -- until now, No. So, we can change it to native.
Did you find any bugs using the native ??

No, the native connector works for me too. Although, I had to change the port to 9000 instead of 8123 for HTTP.

so should I change the https to native or u gonna change it ?

[Samyak2]

I'll do it

[Samyak2]

Looks good! Thank you for contributing this connector. I'm sure the community will benefit greatly from this.

We'll update clickhouse-sqlalchemy to the next version which will likely include the fixes for Int128 when it's released.

[MahmoudElhalwany]

hich will likely include the fixes for Int128 when it's relea

thanks -- this is my first real contribution to open source project -- so I must make it an anniversary 😄