Added customer config #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details. Running from downstreams #12 |
|
This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details. Running from downstreams #12 |
manassolanki
requested changes
Jul 23, 2024
| from pyspark.sql.session import SparkSession | ||
|
|
||
|
|
||
| class CustomerConfig: |
There was a problem hiding this comment.
can you also add the set function, incase we are going to need it. It can be handy.
| ) | ||
| logger.info(f"Num additional clusters: {len(ci_add_l)}.") | ||
| for ci in ci_add_l: | ||
| if ci not in [i.cluster_id for i in cl]: |
There was a problem hiding this comment.
You can create one cluster id set after getting information and can check the ci in cluster_ids
cluster_ids = set([i.cluster_id for i in cl])
for ci in ci_add_l:
if ci not in cluster_ids:
Comment on lines
114
to
121
| logger.info(f"Clusters to be removed: {len(ci_remove_l)}.") | ||
| for ci in ci_remove_l: | ||
| for i, c in enumerate(cl): | ||
| if ci == c.cluster_id: | ||
| logger.info(f"Removing cluster ID {ci}.") | ||
| cl.pop(i) | ||
| break | ||
| logger.info(f"Current cluster count: {len(cl)}") |
There was a problem hiding this comment.
Suggested change
| logger.info(f"Clusters to be removed: {len(ci_remove_l)}.") | |
| for ci in ci_remove_l: | |
| for i, c in enumerate(cl): | |
| if ci == c.cluster_id: | |
| logger.info(f"Removing cluster ID {ci}.") | |
| cl.pop(i) | |
| break | |
| logger.info(f"Current cluster count: {len(cl)}") | |
| logger.info(f"Clusters to be removed: {len(ci_remove_l)}.") | |
| ci_remove_ids = set(ci_remove_l) | |
| final_cluster = [cluster for cluster in cl if cluster.cluster_id not in ci_remove_ids] | |
| logger.info(f"Current cluster count: {len(cl)}") | |
| return final_cluster |
Signed-off-by: Kartikay Bagla <kartikaybagla@gmail.com>
feat: added cluster ids from jobs system tables
manassolanki
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallymake fmtapplied