Fix pdsh build on MacOSX #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A version of the `bool` type was defined in a couple places in pdsh, and on some systems (OSX), different source files were seeing different sizes for this type (int vs byte?), and this caused segfaults when passing a structure full of bool types to a function defined in another source file. Fix this by including `stdbool.h` in macros.h and make sure all sources using bool pull in macros.h, and remove any other bool typedefs from pdsh sources.
Fix assignment of char to char * in hostname_create_with_suffix()
Drop getnetgrent_r in favor of more widely supported getnetgrent(). This function is called before threaded dsh context.
Do not bother initializing modules in _mod_initialize_modules_by_name when an empty list is passed to the function. This may also avoid a potential segfault in list_split.
In opt_args_early(), local variable pc is only used on linux systems with GNU getopt to track setting of POSIXLY_CORRECT environment variable. Suppress warnings on Mac OSX by wrapping the definition of this variable in #ifdef __linux as with the rest of the code.
Fix a useless use of parentheses (compiler warning on osx) and also bad formatting when checking for DSH_READING state.
Probably meant to ignore SIGPIPE not block it.
Check for missing base64 program and fall back to openssl if not found. Since `openssl base64` outputs in PEM format with newlines, use tr(1) to remove newlines and then wrap at desired long line length.
Add OSX to travis-ci builds. Do not attempt to use the travis-ci builder to install dependencies, which proabably aren't needed or won't be used on OSX anyway.
grondo
force-pushed
the
osx-fixes
branch
3 times, most recently
from
4531741 to
042c1d4
Compare
|
Looks good to me. |
|
@garlick, thanks for checking |
|
Now someone else can push the merge button, yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes and cleanup for pdsh on Mac OSX.
There's still a problem building pdsh with genders support on osx, but other parts of pdsh build and are now being tested on the travis-ci osx builder.
Fixes #95