WIP redfishpower: output summary after power cmd #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: DESCRIBE SEOMTHING IN FUTURE WHEN WE DETERMINE PROTOCOL Add counters indicating if a power command is ok, errored, or timedout and output a summary at the end of the power control operation for all hosts specified.
|
closing, this has been supplanted by other work (notably PR #161 work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP per discussion in #79. Obviously shouldn't be used until we determine the actual protocol, but just wanted to make sure
A) it wouldn't be hard to do this. I just used global counters instead of trying to create a "wrapper" data structure, which I think would have made things more difficult than they would have had to be.
B) given an illustration of what we can probably do.