convert still more tests to the sharness framework #104
Conversation
Problem: test/t16 covers the powerman device status command using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: test/t19 and test/t20 cover device timeouts using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: test/t25 and test/t25 cover device delays using the old test infrastructure. Convert to sharness. Remove the old test scripts and data.
| test_expect_success 'powerman -d works' ' | ||
| $powerman -h $testaddr -d >device.out && | ||
| echo "test0: state=connected reconnects=000 actions=002 type=vpc hosts=t[0-15]" >device.exp && | ||
| test_cmp device.exp device.out | ||
| ' |
There was a problem hiding this comment.
i actually didn't know what -d was and noticed it wasn't in the manpage :-) intentional b/c it's a debugging thing? or error?
There was a problem hiding this comment.
Looks like the man page has -D,--device but not -d,--device-all so I guess yeah, an unintentional omission. I'll open a bug.
| test_expect_success 'create test powerman.conf with cycle of only delay' ' | ||
| cat >powerman.conf <<-EOT | ||
| specification "vpcfakecycle" { | ||
| timeout 2 | ||
| plug name { "0" "1" "2" "3" "4" "5" "6" "7" "8" | ||
| "9" "10" "11" "12" "13" "14" "15" } | ||
| script login { | ||
| send "login\n" | ||
| expect "[0-9]* OK\n" | ||
| expect "[0-9]* vpc> " | ||
| } | ||
| script cycle { | ||
| delay 0.01 | ||
| } | ||
| } | ||
| listen "$testaddr" | ||
| device "test0" "vpcfakecycle" "$vpcd |&" | ||
| node "t[0-15]" "test0" | ||
| EOT | ||
| ' |
There was a problem hiding this comment.
i'm just curious, is there an old device that didn't output anything when doing a cycle? Just didn't quite understand the purpose of this test compared to the one below.
There was a problem hiding this comment.
I wasn't too sure what that was about either but I figured it must've been a concern at some point so I'd bring it over.
t/t0004-status-query.t
Outdated
| wait | ||
| wait |
There was a problem hiding this comment.
No, we are waiting for two processes, the vpcd and powermand. Ugh, no && though! Will fix.
Problem: test/t48 cover device connection over tcp using the old test infrastructure. Convert to sharness. Incorporate it into the existing t0004-status-query.t since it follows the same pattern. Remove the old test scripts and data.
Problem: the list of tests in test/README is out of date. Remove the tests that have been converted to sharness thus far.
garlick
force-pushed
the
sharness_conv3
branch
from
66f0832
to
b281097
Compare
|
Fixed the missing && and so I'll set MWP - thanks! |
Here's another batch of conversions.