convert old school power control box tests to sharness #108
Conversation
Problem: test/t21 and t22 cover baytech rpc3-nc power control devices using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: test/t23 and t24 cover baytech rpc28-nc power control devices using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: test/t27 and t28 cover baytech rpc3 power control devices using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: test/t29, t30, t33, t34 cover LNXI icebox v3, v4 power control using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
t/t0019-insteon-plm.t
Outdated
| test_expect_success 'powerman -q shows all off' ' | ||
| $powerman -h $testaddr -q >query3.out && | ||
| makeoutput "" "t0" "t1" >query3.exp && | ||
| test_cmp query3.exp query3.out | ||
| ' |
There was a problem hiding this comment.
not all off, seems t1 is being checked for unknown
t/t0019-insteon-plm.t
Outdated
| echo $! >powermand.pid && | ||
| $powerman --retry-connect=100 --server-host=$testaddr -d | ||
| ' | ||
| test_expect_success 'powerman -q shows all t0 off, t1 unknown' ' |
There was a problem hiding this comment.
perhaps add comment from device file about # N.B.: X10 devices will always show power status "unknown". , t1 always being unknown sorta weird for uniniated.
There was a problem hiding this comment.
Thanks for that reminder - I did not dig deep enough to remember that while converting the test. Will add a note.
| @@ -147,8 +147,6 @@ AC_CONFIG_FILES( \ | |||
| test/sierra.conf \ | |||
| test/t19.conf \ | |||
| test/t20.conf \ | |||
| test/t31.conf \ | |||
There was a problem hiding this comment.
commit message error, you mean t31 & t32
Problem: test/t31 and t32 cover LNXI icebox v2 power control devices using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: powerman includes tests for the hp3488 and ics8064 GPIB switch modules using the gpib-utils project, but that project is largely abandoned. Leave the dev scripts in case anyone is using them but drop the simulator and tests.
Problem: t19 and t20 were converted to sharness but the original tests were not removed. Remove old test scripts and data
Problem: test/t46 covers cyclades pm series power control devices using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: test/t41 covers the insteon power line modem device using old test infrastructure. Convert to sharness. Remove the old test scripts and data.
Problem: the list of tests in test/README is out of date. Remove the tests that have been converted to sharness thus far.
garlick
force-pushed
the
sharness_conv4
branch
from
0dd26aa
to
042fe6b
Compare
|
Thanks! Pushing fixes and setting MWP. |
|
oops, I pushed changes and set MWP right afterwards, but apparently the earlier passing tests were sufficient for mergify to merge without waiting for CI to finish. That's not good - any idea how to fix that? It doesn't work that way in the flux repos AFAIK |
|
Hmmmmm I’m wondering if we need to add a branch protection too. I’ll look into it. |
|
dunno if this will fix it, but set these branch protections that these builders gotta complete
|
|
That seems like it has a high probability of success. Thanks :-) |
This converts the tests for icebox, baytech, cyclades - the devices powerman was originally developed to control.
Also I dropped the gpib testing since the other project it depends on is no longer developed (dev scripts remain).
Finally, the insteon plm test is converted.