redfishpower: minor cleanup #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The English in a set of comments isn't the most clear. Add some words that would make the paragraph clearer.
Problem: Values in struct timeval are signed, not unsigned. A parameter to a function assigning to timeval tv_usec used "unsigned int" as the parameter type. Update function parameter from unsigned int to long int, matching the type of timeval tv_usec.
Problem: The internal macro WAIT_UNTIL_DELAY is not very clear. And it may be confusing given the internal "delayed cmds" data structure. Rename it to STATUS_POLLING_INTERVAL.
Problem: There is a small chunk of redfishpower logic surrounding delayedcmds that could use some extra clarification. Add note that delayedcmds ready to be sent out will be moved to the activecmds list.
chu11
force-pushed
the
redfishpower_cleanup
branch
from
d383478
to
c6e6cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peeling off several commits from multiple other WIP PRs, all minor stuff