don't allocate a pseudo-terminal for each coprocess #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the toy 'bashfun' device seems to be the only thing that requires a pty. Drop device script and test.
Problem: xpty.c contains functions that have nothing to do with ptys. Rename to fdutil and update users.
Problem: a large configuration with many coprocesses uses up pseudo-terminals, which may have limited availability. Start coprocesses with socketpair(2) and fork(2) instead of forkpty(3). Fixes chaos#133
Problem: pty-related utility functions in fdutil.c are now unused. Drop them and the autoconf gunk for forkpty(3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: powerman allocates a pty to each coprocess, which may impact scalability to many coprocs without really much benefit.
Just use a raw socket instead.