reduce log noise #140
reduce log noise #140
Conversation
A) There's the part of me that thinks it should stay, almost exclusively for the fact that the tool is still suffixed with a B) This seems like a big enough change, I think it should be another PR. |
| TcpDev *tcp; | ||
|
|
||
| assert(dev->connect_state == DEV_CONNECTING | ||
| || dev->connect_state == DEV_CONNECTED); | ||
| tcp = (TcpDev *)dev->data; |
There was a problem hiding this comment.
this code removal doesn't seem related to the "reduce log noise" commit. Seems like it's just dead code, meant for another commit and forgot it was in this one?
There was a problem hiding this comment.
Actually I changed some logging code and as a result, tcp became a set but not used error. The full diff is
@ -259,11 +255,8 @@ bool tcp_connect(Device * dev)
*/
void tcp_disconnect(Device * dev)
{
- TcpDev *tcp;
-
assert(dev->connect_state == DEV_CONNECTING
|| dev->connect_state == DEV_CONNECTED);
- tcp = (TcpDev *)dev->data;
dbg(DBG_DEVICE, "tcp_disconnect: %s on fd %d", dev->name, dev->fd);
@@ -274,8 +267,7 @@ void tcp_disconnect(Device * dev)
dev->fd = NO_FD;
}
- if (!tcp->quiet)
- err(false, "tcp_disconnect(%s): disconnected", dev->name);
+ dbg(DBG_DEVICE, "tcp_disconnect(%s): disconnected", dev->name);
}
void tcp_preprocess(Device *dev)
It's a fair bit of code to keep around with no motivating use case...
Sure, that seems fine. |
|
OK this is now based on top of #141 |
Problem: in the recent conversion of coprocesses from forkpty(3) to socketpair(2), the unused side of the pair is not closed in the parent, which causes file descriptors to leak as coprocesses are restarted on error. Close the file descriptor in the parent. Close its counterpart in the child (just good hygiene, not a leak).
Problem: when we run the test suite, on/off messages appear in syslog. There is no longer a need to log anything directly to syslog. When run under systemd, the systemd journal captures stderr (and routes to syslog if so configured). Log those messages to stderr. Use a <level> prefix to preserve the ability to set the severity of those messages in the config file. Fixes chaos#138
Problem: when there are many devices, logging connect/disconnect can produce a lot of log noise. Turn these messages into DBG_DEVICE messages. Fixes chaos#139
Problem: client connect/disconnect logging is not that useful. Don't log when EOF or XPOLLHUP is received from a client.
Problem: dbg_notty() and error_notty() are no longer used now that the powerman server no longer forks. Drop those functions and associated syslog logging methods.
|
Tidied up and rebased on master. |
This tightens up powerman logging and eliminates some unused stuff: