Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfishpower: adjust verbosity output #151

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Feb 28, 2024

splitting off of the big PR as it's rather independent of everything else.

basically the most verbose stuff in redfishpower is output at "level 1" verbosity, which is annoying. have different levels.

Problem: In the future it will be useful to have verbosity
increased only for testing scenarios.

Allow verbosity to be increased at multiple levels by specifying
it multiple times on the command line.

Update redfishpower(8) accordingly.
Problem: When debugging it would be useful to know what the "true"
power status is rather than the generic "unknown" when the status
is not "on" or "off".

Add extra verbose output when the status is "unknown".
Problem: Currently curl's extremely verbose output is output at
"level 1" verbosity.  It should be output at a higher level.

Output curl's verbose output only at level 3 and higher.
Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 3494465 into chaos:master Feb 29, 2024
8 checks passed
@chu11 chu11 deleted the redfishpower_verbosity branch February 29, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants