powerman: support status_ranged script #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: in powerman.dev(5) the ranged scripts are typoed as "range". Correct the typoes.
Problem: Some text describing the selection of the status_all vs status scripts is invalid. Simply remove the offending text.
Problem: in the near future we would like to create a PlugList from a List of Plugs. It is currently inconvenient to create such a list given the current PlugList API. Add a function pluglist_copy_from_list() function to create a PlugList from a List of Plugs.
Problem: "ranged" version of scripts (on_ranged, off_ranged, etc.) were supported a long time ago. A need was not there for a status_ranged because it was never needed. However, in the future there will be scenarios where it may be needed. Support a "status_ranged" script.
Problem: ipmipower supports passing ranged hosts to check power status, but it is not utilized. Use the status_range script over the status_all script in ipmipower.dev.
Problem: The new status_ranged script is not documented. Add documentation in powerman.dev(5)
|
OK to sit on this until we get everything else done and then decide if it's needed? My feeling is it probably is not needed, and we should not further convolute device "API" if there's not a good reason. |
|
sounds good. I'll peel off some of the cleanup commits into #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per discussion in #128, I was going to punt on this till later, but my mini-hack prototype ended up working. I began to understand the code better, so figured ... why not.