redfishpower: add extra timeout debug information #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: in powerman.dev(5) the ranged scripts are typoed as "range". Correct the typoes.
Problem: Some text describing the selection of the status_all vs status scripts is invalid. Simply remove the offending text.
garlick
approved these changes
Mar 1, 2024
src/redfishpower/redfishpower.c
Outdated
Comment on lines
374
to
376
| /* strp - on, off, unknown | ||
| * realstrp - on, off, poweringon, poweringoff, unknown | ||
| */ |
There was a problem hiding this comment.
Update comment for changed variable names?
Problem: There are times it would be convenient to know the actual redfish power status returned, rather than the internally mapped "on", "off", or "unknown" power status. Update parse_onoff() to optionally return additional redfish power status. The additional redfish power status returns are "paused", "powering off", and "powering on". Update variable names that call this function to be consistent.
Problem: When powering on a target, it will sometimes enter the "PoweringOn" state but regress back to the "off" state. This is likely due to a hardware problem. It can be hard to diagnose when the only clue is a power on has "timed out". Add some additional output to help diagnose this situation.
chu11
force-pushed
the
redfishpower_extra_debug
branch
from
f4c4fd6
to
fe49841
Compare
At the moment they get it just via telemetry output. Not great, but it's something ... vs the nothing before this (I had to run redfishpower by hand in verbose mode and see what was going on). Once we work on #79 / #85, perhaps some of it can migrate to the user. |
|
thanks, setting MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When powering on a target, it will sometimes enter the "PoweringOn" state but regress back to the "off" state. This is likely due to a hardware problem. It can be hard to diagnose when the only clue is a power on has "timed out".
Add some additional output to help diagnose this situation.
some cleanups added on top