redfishpower: fix memleaks and test under valgrind #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
Mar 28, 2024
src/redfishpower/redfishpower.c
Outdated
Comment on lines
374
to
379
| if (pm->hostname) | ||
| xfree(pm->hostname); | ||
| if (pm->plugname) | ||
| xfree(pm->plugname); | ||
| if (pm->parent) | ||
| xfree(pm->parent); |
There was a problem hiding this comment.
The checks for non-NULL are unnecessary.
Problem: Checking for NULL before calling xfree() is unnecessary. Remove unnecessary checks.
Problem: A few fields in the power message struct are not freed on destruction. Free memory of appropriate fields on destruction.
Problem: A cut and paste error has lead to the waitcmds list not calling a destructor when items on the list are removed. Set the destructor on the correct list.
Problem: There is no coverage for memory leaks in redfishpower. Add memleak test in t0034-redfishpower.t test file. Fixes chaos#166
chu11
force-pushed
the
redfishpower_valgrind
branch
from
4c77ccf
to
7cf939d
Compare
|
thanks. re-pushed with an extra commit to cleanup those unnecessary NULL checks and adjusted commit as well. |
|
Feel free to set MWP when you're done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSIA
Note, can be reviewed indepedently of #167 and #168