powerman: use singlet script if targeting one plug #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When selecting a script to use for an action (i.e. power on) powerman may select the "all" or "ranged" script if they are available. This is done even if a single plug is targeted. There is nothing wrong with this, but may not be what users expect. If the user is specifically targeting only one plug, select the singlet script over any other script.
Problem: The vpcd simulator does not support "ranged" scripts, which limits its use in testing. Add "ranged" script support in vpcd and at ranged scripts in vpc.dev.
Problem: There are no tests to ensure singlet vs ranged vs all scripts are correctly chosen from a device file. Modify / add tests via t0006-on-off-cycle.t.
|
FYI based on conversation in #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When selecting a script to use for an action (i.e. power on) powerman may select the "all" or "ranged" script if they are available. This is done even if a single plug is targeted. There is nothing wrong with this, but may not be what users expect.
If the user is specifically targeting only one plug, select the singlet script over any other script.